The following set of patches fix known issues with the 2.6.9 NFS client code, and significantly enhance the support for NFSv4.
RPC: Convert rpciod into a work queue for greater flexibility.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Remove the rpc_queue_lock global spinlock. Replace it with per-rpc_queue spinlocks
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Make readdirplus create dentries on the fly when we're running through the directory.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: The fact that readdirplus calls now create dentries from within readdir calls renders nfs_cached_lookup() obsolete.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Change rpc_ops->create() to take a dentry argument rather than a qstr.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Make nfs4_do_open() take a dentry argument.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: setattr, close and open_downgrade should use the state_owner's credentials when they are available.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Convert the NFSv4 close and open_downgrade operations to use asynchronous RPC calls.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPCSEC_GSS: When the gss code notices that a cred has expired, mark the cred containing the context non-uptodate, triggering creation of a new context.
Note that on the send-side operations (get_mic, wrap), we mark the cred as not uptodate, but continue trying to use it; the server can complain if it wants to, and the next time through we'll refresh it.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Instead of setting a flag (RPCAUTH_CRED_DEAD) in the cred to indicate failure of an upcall to get a gss context for that cred, set the status of waiting tasks to indicate failure.
This solves problems e.g. with creds with the CRED_DEAD flag set never being refreshed, which caused krb5 mounts to fail after the context used to do RENEWS expired.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: The RPCAUTH_CRED_DEAD flag had been unused for some time before I unwisely revived it for use with the gss code. Having removed that use from the gss code, it's time to remove all references to it.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPCSEC_GSS: Miscellaneous cleanup of auth_gss.c: we're passing something as a void * when we know perfectly well what it is. And we're passing some arguments that we don't actually use.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Sync NFS writes still use kmalloc
Replace the kmalloc() and kfree() calls in this path with appropriate invocations of nfs_writedata_alloc() and nfs_writedata_free(). This makes nfs_writepage_sync match all the other write paths in fs/nfs/write.c.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv2/v3/v4: ESTALE should not be a permanent condition on directories.
Although it usually means that someone has deleted a file on the server, the ESTALE error may also indicate that the sysadmin has used exportfs to deny our client access to the server. Most NFS implementations therefore consider it a non-permanent condition, and allow inodes to "recover" when the sysadmin re-enables access. If, however, you want to work with broken servers, like unfsd, that reuse filehandles for new files after the original file gets deleted, then "recovery" is impossible, since it may be that the filehandle now points to a different file. Note that this is broken server behaviour that may happen even without us ever seeing the ESTALE error. In order to minimize (but we can never eliminate entirely) this race condition on unfsd servers, Linux has traditionally made ESTALE a permanent condition on all filehandles except the root filehandle.
The problem is that if we apply this strict staleness criterion to directories (particularly so for he current directory), then all processes will need to re-walk the path starting from the mount point, in order to recover from the sysadmin intervention case. As this is not usual on other *NIX implementations, and may in any case be undermined by caching rules etc, this is being seen as a usability problem.
This patch makes ESTALE a non-permanent condition on directories, but preserves the current behaviour for non-directories.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
VFS: Avoid dentry aliasing problems in filesystems like NFS, where inodes may be marked as stale in one instance (causing the dentry to be dropped) then re-enabled in the next instance.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Optimize away unnecessary del_timer_sync() operations, when we know there are no pending timers.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: when we mount with the "nolock" flag we need to use local locking.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
VFS: Remove LOCK_USE_CLNT. It should no longer be necessary.
NFS: when we mount with the "nolock" flag we need to use local locking.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Fix dentry refcount accounting error which causes unnecessary sillyrenames when renaming to an existing file.
Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: short write warning
Recently a patch set was accepted to allow the Linux NFS client to handle short writes by retrying the unwritten portion of the request. The only case that now results in an error is when the server makes no progress; that is, writes zero bytes.
This patch changes the kernel log warning that is generated in that case to reflect the error condition more accurately.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: report return code on GETATTR and SETATTR
Improve trace debugging messages for NFSv2/3 GETATTR and SETATTR procedures.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: display XIDs in host order
Ethereal and other tools display RPC XIDs in host order. This patch changes the RPC trace messages that display XIDs to print them in host order so they can be easily matched to XIDs that appear in Ethereal.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Use sizeof() instead of C macro
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: better handling of short writes in direct write path
Immediately return control to the application if a short NFS write is detected in the NFS client's direct write path. This is better behavior than what the direct write path does today, which could result in data appearing at the wrong offset in the file.
Eventually this code path should retry short writes at least once before giving up.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Direct write path allocates nfs_write_data on the stack
Reduce stack utilization in the NFS direct write path by using a dynamically allocated nfs_write_data structure instead of allocating one on the stack. This reduces stack utilization of nfs_direct_write_seg from over 900 bytes to less than 100 bytes.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Direct read path allocates nfs_read_data on the stack
Reduce stack utilization in the NFS direct read path by using a dynamically allocated nfs_read_data structure instead of allocating one on the stack. This reduces stack utilization of nfs_direct_read_seg from over 900 bytes to less than 100 bytes.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Use parallel read operations to do direct read requests
The initial implementation of NFS direct reads was entirely synchronous. The direct read logic issued one NFS READ operation at a time, and waited for the server's reply before issuing the next one. For large direct read requests, this is unnecessarily slow.
This patch changes the NFS direct read path to dispatch NFS READ operations for a single direct read request in parallel and wait for them once. The direct read path is still synchronous in nature, but because the NFS READ operations are going in parallel, the completion wait should be much shorter.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Direct reads and writes need to flush dirty cache pages
Other parts of the NFS client invoke nfs_wb_all() when they want to flush dirty cache pages. The direct path needs to do that, too.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: use attribute timeout instead of "noac" mount option
The behavior enabled by the "noac" mount option should be precisely equivalent to setting acreg{min,max} or acdir{min,max} to zero via mount options.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Ensure ACCESS caches are invalidated together with the attribute cache.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: incorrect "df" results
Fix an NFS client bug introduced in 2.6.9-rc1. The "df" command was reporting the size of NFS file systems incorrectly.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
All of the above patches rolled into one.