Return to main menuThe following set of patches fix known issues with the 2.6.7 NFS client code, and significantly enhance the support for NFSv4.
VFS: Minimal fix to posix_same_owner() to only use the fl_owner_t field in all cases when the caller is not lockd
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
VFS: More extensive fix to locking code. Add file_lock_operations to deal with copy/release of private data in the file_lock->fl_u field. Add filesystem hooks for steal_locks(): changing the lockowner is hardly supported concept in most file locking protocols.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4 server: Fix up nfs4state.c to support the file_lock_operations, and the lock_manager_operations.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NLM/lockd: Fix up lockd to make use of the new interface. In particular set up fl_compare_owner() methods for both client and server.
NLM/lockd: Make the client release all locks in a "steal_locks" situation.
NLM/lockd: Fix up copying/release of the file_lock->fl_u.nfs_fl private data.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NLM/lockd: set up a unique mapping between the fl_owner_t and a unique 32-bit "pid" on the client side. We can't use the real pid of the process/thread 'cos CLONE_FILES does not automatically imply CLONE_THREAD.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NLM/lockd: Move fl_insert, fl_remove, into struct file_lock_operations.
NLM/lockd: Move fl_notify, into struct lock_manager_operations.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NLM/lockd/NFSv3/CIFS: Make the filesystem responsible for calling posix_lock_file() if it needs to. This means it can be done under the correct atomicity locks.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Locking NFSv2/v3: clean up nfs_lock().
Locking NFSv2/v3: fcntl(GETLK) doesn't need to write back any data.
Locking NFSv2/v3: fix a potential lock leak on the server.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: set a more reasonable value for the READDIR "dircount" field.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Ensure that rpc_clone_client() references its true parent.
RPC: Fix some initializers in rpc_clone_client().
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv3/v4: be more efficient when doing ACCESS RPC calls. Always ask for the full set of permissions.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Optimizing away the case of negative dentries in nfs_open_revalidate() avoids several atomicity problems.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Fix the symlink overflow bug.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Tighten call_verify() checks for truncated messages.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPCSEC_GSS/krb5: Remove an unused parameter.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
NFSv4: OK, so it's trivial and probably superfluous, but I don't see why we shouldn't be slightly stricter here, so I'm just going to keep sending this until I'm told to stop.... Make sure that unmapped errors are approximately in the range of defined NFS4 errors.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
RPCSEC_GSS: Missing newline in dprintk.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
RPCSEC_GSS/spkm3: Add the spkm3 common and client-side code.
From Andy Adamson <andros@citi.umich.edu>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
NFS read/write: Break the nfs_wreq_lock into per-mount locks. This helps prevent a heavy read and write workload on one mount point from interfering with workloads on other mount points.
Note that there is still some serialization due to the big kernel lock.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv2/v3: Clean up the logic that handles recovery from a failed mount request.
NFSv2/v3: Get rid of nfs_put_super.
Signed-off-by: Chuck Lever <cel@netapp.com>
NFSv2/v3: advertise the "wsize" setting as the optimal I/O block size.
Signed-off-by: Chuck Lever <cel@netapp.com>
NFS: creates an efficient mechanism for comparing file handles that ignores the unused bytes in a file handle.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFS: Now that file handle comparison ignores the unused parts of the file handle container, there is no longer any need to clear the file handle container before copying in a file handle. This allows us to remove a 128 byte memset() from several hot paths.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Kconfig: In the kernel help for NFSv3 & NFSv4 client support both are listed as "the newer version ... of the NFS protocol"
Patch by Jesper Juhl <juhl-lkml@dif.dk>
NFSv2: In the NFSv3 RFC, the sattr3 structure passed in the SETATTR call allows for the client to request that the mtime and/or atime of an inode be set to the current server time, the given (client) time, or not changed. The set-to-current-server value is used when you run "touch file" on the client.
The NFSv2 RFC defines no such encoding for the sattr structure. However Solaris and Irix machine obey a convention where passing the invalid value mtime.useconds=1000000 means "set both mtime and atime to the current server time". The convention is documented in the book "NFS Illustrated" by Brent Callaghan. The patch below implements this convention for the Linux client and server (hence multiple To:s).
Patch by Greg Banks <gnb@sgi.com>
NFSv4: Fix up the exception handling. Ensure we always handle NFS4ERR_DELAY properly.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Clean up the reboot recovery. Ensure that we exclude stateful operations by using a per-server read/write semaphore.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: On server reboot we need to recover byte-range locks.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Prime SETCLIENTID call for the delegation callback info.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv2/v3/v4: Place NFS nfs_page shared data into a single structure that hangs off filp->private_data. As a side effect, this also cleans up the NFSv4 private file state info.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: More cleanups of the NFSv4 state.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Basic code for managing delegation state.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Delegation callback server.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: XDR cleanups in preparation for delegations.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: XDR cleanups in preparation for delegations.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Service delegation recall requests from the server.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: More delegation recall code
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Recover delegations on server reboot.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Delegated open.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: More aggressive caching if we have a delegation.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
NFSv4: Enable delegations by actually telling the server about our recall ability.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Convert rpciod into a work queue for greater flexibility.
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
RPC: Remove the rpc_queue_lock global spinlock. Replace it with per-rpc_queue spinlocks
Signed-off-by: Trond Myklebust <trond.myklebust@fys.uio.no>
All of the above patches rolled into one.