Subject: [PATCH] NFS: report return code on GETATTR and SETATTR Improve trace debugging messages for NFSv2/3 GETATTR and SETATTR procedures. Signed-off-by: Chuck Lever Signed-off-by: Trond Myklebust --- fs/nfs/nfs3proc.c | 10 +++++----- fs/nfs/proc.c | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff -X /home/cel/src/linux/dont-diff -Naurp 02-nfs-short-write-msg/fs/nfs/nfs3proc.c 03-nfs-getattr-msgs/fs/nfs/nfs3proc.c --- 02-nfs-short-write-msg/fs/nfs/nfs3proc.c 2004-10-18 17:54:08.000000000 -0400 +++ 03-nfs-getattr-msgs/fs/nfs/nfs3proc.c 2004-10-21 10:35:24.465411000 -0400 @@ -80,10 +80,10 @@ nfs3_proc_get_root(struct nfs_server *se dprintk("%s: call fsinfo\n", __FUNCTION__); info->fattr->valid = 0; status = rpc_call(server->client_sys, NFS3PROC_FSINFO, fhandle, info, 0); - dprintk("%s: reply fsinfo %d\n", __FUNCTION__, status); + dprintk("%s: reply fsinfo: %d\n", __FUNCTION__, status); if (!(info->fattr->valid & NFS_ATTR_FATTR)) { status = rpc_call(server->client_sys, NFS3PROC_GETATTR, fhandle, info->fattr, 0); - dprintk("%s: reply getattr %d\n", __FUNCTION__, status); + dprintk("%s: reply getattr: %d\n", __FUNCTION__, status); } return status; } @@ -101,7 +101,7 @@ nfs3_proc_getattr(struct nfs_server *ser fattr->valid = 0; status = rpc_call(server->client, NFS3PROC_GETATTR, fhandle, fattr, 0); - dprintk("NFS reply getattr\n"); + dprintk("NFS reply getattr: %d\n", status); return status; } @@ -119,7 +119,7 @@ nfs3_proc_setattr(struct dentry *dentry, dprintk("NFS call setattr\n"); fattr->valid = 0; status = rpc_call(NFS_CLIENT(inode), NFS3PROC_SETATTR, &arg, fattr, 0); - dprintk("NFS reply setattr\n"); + dprintk("NFS reply setattr: %d\n", status); return status; } @@ -198,7 +198,7 @@ static int nfs3_proc_access(struct inode if (res.access & (NFS3_ACCESS_LOOKUP|NFS3_ACCESS_EXECUTE)) entry->mask |= MAY_EXEC; } - dprintk("NFS reply access, status = %d\n", status); + dprintk("NFS reply access: %d\n", status); return status; } diff -X /home/cel/src/linux/dont-diff -Naurp 02-nfs-short-write-msg/fs/nfs/proc.c 03-nfs-getattr-msgs/fs/nfs/proc.c --- 02-nfs-short-write-msg/fs/nfs/proc.c 2004-10-18 17:55:21.000000000 -0400 +++ 03-nfs-getattr-msgs/fs/nfs/proc.c 2004-10-21 10:35:24.468408000 -0400 @@ -63,12 +63,12 @@ nfs_proc_get_root(struct nfs_server *ser dprintk("%s: call getattr\n", __FUNCTION__); fattr->valid = 0; status = rpc_call(server->client_sys, NFSPROC_GETATTR, fhandle, fattr, 0); - dprintk("%s: reply getattr %d\n", __FUNCTION__, status); + dprintk("%s: reply getattr: %d\n", __FUNCTION__, status); if (status) return status; dprintk("%s: call statfs\n", __FUNCTION__); status = rpc_call(server->client_sys, NFSPROC_STATFS, fhandle, &fsinfo, 0); - dprintk("%s: reply statfs %d\n", __FUNCTION__, status); + dprintk("%s: reply statfs: %d\n", __FUNCTION__, status); if (status) return status; info->rtmax = NFS_MAXDATA; @@ -96,7 +96,7 @@ nfs_proc_getattr(struct nfs_server *serv fattr->valid = 0; status = rpc_call(server->client, NFSPROC_GETATTR, fhandle, fattr, 0); - dprintk("NFS reply getattr\n"); + dprintk("NFS reply getattr: %d\n", status); return status; } @@ -114,7 +114,7 @@ nfs_proc_setattr(struct dentry *dentry, dprintk("NFS call setattr\n"); fattr->valid = 0; status = rpc_call(NFS_CLIENT(inode), NFSPROC_SETATTR, &arg, fattr, 0); - dprintk("NFS reply setattr\n"); + dprintk("NFS reply setattr: %d\n", status); return status; }