[Labeled-nfs] [PATCH 1/7] Security: Add inode_{get, set}secid LSM hooks and security helper functions

[James Morris]

On Wed, 1 Aug 2007, David P. Quigley wrote:

> + * @inode_getsecid:
> + * 	Returns secid from @inode;

Probably best to specify that this happens via *secid.

> + * @inode_setsecid:
> + * 	Set the security structure value of @inode with @sid.
> + * 	Returns 0 on success.

Except when it returns void :-)

> +	void (*inode_getsecid)(struct inode *inode, u32 *secid);
> +	void (*inode_setsecid)(struct inode *inode, u32 secid);

> +static inline void security_inode_setsecid(struct inode *inode, u32 sid)
> +{
> +	if (unlikely (IS_PRIVATE (inode)))

Please remove the extra spaces.


-- 
James Morris
<jmorris at namei.org>