[Labeled-nfs] [PATCH 08/13] NFS: Introduce lifecycle managment for label attribute.

James Morris jmorris at namei.org
Mon Nov 19 16:44:22 EST 2007


On Mon, 19 Nov 2007, Matthew N. Dodd wrote:

> > 
> > You need to check the return of kmalloc().
> 
> If kmalloc() returns NULL then any label data returned by the GETATTR
> operation will not be used.  Labeling would be performed by the policy in the
> 'd_instantiate' function.

I suspect this would lead to inconsistent behavior & confuse folk.  
Perhaps try and return an error (which seems typical in much of the 
surrounding code) as a first option.

-- 
James Morris
<jmorris at namei.org>


More information about the Labeled-nfs mailing list