[Labeled-nfs] [PATCH 08/13] NFS: Introduce lifecycle managment for label attribute.

Matthew N. Dodd Matthew.Dodd at sparta.com
Mon Nov 19 17:28:30 EST 2007


James Morris wrote:
> On Mon, 19 Nov 2007, Matthew N. Dodd wrote:
> 
>>> You need to check the return of kmalloc().
>> If kmalloc() returns NULL then any label data returned by the GETATTR
>> operation will not be used.  Labeling would be performed by the policy in the
>> 'd_instantiate' function.
> 
> I suspect this would lead to inconsistent behavior & confuse folk.  
> Perhaps try and return an error (which seems typical in much of the 
> surrounding code) as a first option.

panic() seems simpler.


More information about the Labeled-nfs mailing list