Delay in WRITE delegation recall during COMMIT

J. Bruce Fields bfields at fieldses.org
Fri Aug 18 21:42:06 EDT 2006


On Fri, Aug 18, 2006 at 05:10:50PM -0700, Ajay Gulati wrote:
>     I am assuming you meant filp (struct file *), when you mentioned
> filehandle.

Yes, sorry.

> was wondering if it would be hard to  not use nfsd_open()
> during nfsd_commit()?
> I modified nfsd_commit() to use dentry_open() instead of nfsd_open(). The
> same thing as write wasn't possible currently because nfsd4_write has
> stateid which makes it easy to get filp. The "COMMIT" only has offset and
> count.

Hm.  I suppose you could probably contrive some way to look up the
filehandle from the commit operation arguments.

> I am attaching the patch below, which seems to work. I modified __setlease()
> also to get write delegation and test the patch. I am looking into making
> delegations work without the modification in __setlease(), if you have any
> ideas on that please let me know.

Might work.  Though nfsd_open has some stuff (fh_verify and some other
checks) and I'd have to think about whether it's safe to skip those.

--b.


More information about the NFSv4 mailing list