Fwd: Re: can we combine posix_test_lock and posix_lock_file ?

[Trond Myklebust]

On Tue, 2006-12-19 at 06:40 -0800, Dharmosoth Seetharam wrote:
> Hi,
> 
> 
> can you please tell me "What are the scenarios to 
> reproduce the problem"
> 
> I am using NLMv4, NFSv3 and Kernel 2.6.7.

I don't recall that there were any actual races: the BKL should normally
be protecting you against that.

The main problem with the old code was that it was inefficient (why
would you want to go through the linked list 2 or 3 times in order to
retrieve the same information) and in particular that the old
posix_test_lock would return a pointer to a variable in its own private
stack space (which gets deallocated when the function returns).

Trond