[PATCH 13/17] nfsd4: add per-operation server stats

Neil Brown neilb at suse.de
Fri Jul 7 03:49:23 EDT 2006


On Tuesday July 4, shanand at novell.com wrote:
> Hi,
> 
> >>> On 6/28/2006 at 2:21 AM, "J.Bruce Fields" <bfields at fieldses.org>
> wrote:
> > On Tue, Jun 27, 2006 at 03:10:23PM -0400, Talpey, Thomas wrote:
> >> Oh yeah. I guess I blotted that out of my mind, thanks. :-)
> >> Op 2 was reserved because proc 2 is. (Yecch.) Of course,
> >> OP_CB_GETATTR promptly reused OP_ACCESS.
> >> 
> >> I still agree with Neil - don't 3-base the stats.
> > 
> > OK.  Shankar, could you revise this patch and the nfs-utils patches?
> 
> The modified patch is attached with this e-mail.
> 
> Instead of tracking using NUMNFS4OPS, I have used FIRST_NFS4OP 
> and LAST_NFS4OP (both defined in nfs4.h). This might help while
> adding new operations in future.
> 
> Also now the v4 server stats array is 0-based and three inirial '0's
> get printed in /proc/net/rpc/nfsd.
> 
> Shankar

Thanks.
I made a couple of changes before submitting it including
- fixed up some white-space issues.
- removing nfsd4_init_opstats which wasn't needed or used.
- open coding nfsd4_show_opstats as I could see no value in the
  separate function,

NeilBrown


More information about the NFSv4 mailing list