[patch 5/6] Implement a new version of lucid spkm3 context.
J. Bruce Fields
bfields at fieldses.org
Tue Oct 31 18:28:43 EST 2006
On Mon, Oct 30, 2006 at 02:35:32PM -0500, Trond Myklebust wrote:
> On Mon, 2006-10-30 at 12:51 -0500, J. Bruce Fields wrote:
> > On Mon, Oct 16, 2006 at 08:41:57PM -0400, J. Bruce Fields wrote:
> > > On Tue, Oct 17, 2006 at 09:54:06AM +1000, Neil Brown wrote:
> > > > On Friday October 13, trond.myklebust at fys.uio.no wrote:
> > > > > On Fri, 2006-10-13 at 15:35 -0400, kwc at citi.umich.edu wrote:
> > > > > > @@ -51,6 +51,7 @@
> > > > > > *
> > > > > > * buf->length should be:
> > > > > > *
> > > > > > + * version 4
> > > > >
> > > > > How is this versioning useful? There doesn't appear to be any
> > > > > provisioning for a fallback to previous versions for kernels that don't
> > > > > support version 4. Am I missing something?
> > > >
> > > > Ping? I would like to see the answer to this one too.
> >
> > By the way, here's the kernel side of that change. Opinions?
...
...
> The above indentation looks screwy. Why are you changing it?
> The indentation on the entire function above looks screwed up. Please
> use 8-character tabs instead of spaces.
OK, thanks for reading through that. I believe I've addressed all those
comments. I also split out the xdr_process_buf thing into a separate
patch. And I'm resending an earlier patch that removes some unnecessary
debugging code; I'll post those as followups.
--b.
More information about the NFSv4
mailing list