[PATCH 00/13] nfsd patches

Neil Brown neilb at suse.de
Mon Sep 4 19:04:16 EDT 2006


On Friday September 1, bfields at fieldses.org wrote:
> This is mostly minor gss and nfsd4 cleanup, then some major surgery to the
> nfsd4 acl implementation, followed by a revision of the fslocation patches.
> 
> I believe the fslocations patches take into account everything you noticed in
> your previous review; but other than that they don't have any major changes.
> 

Thanks.
The minor cleanups are fine.
I must confess that my eyes glazed over a bit while reading the ACL
patches, but nothing jumped out at me so I'll assume they are fine (or
as fine as anything ACL related can be :-( )

So all that will go upstream.

The fslocations is nearly fine.  Just some minor formatting issues in
the 'exports' file that bother me as I mentioned.

Just to clarify that:
/proc/fs/nfsd/exports could now have content like:

/path/to/fs hostname(rw,no_root_squash,async,anon_uid=1234,refer=/foo/bar at jupiter:saturn,/home/my files at mars:mercury)

The two issues are:
  - pathnames can have spaces, commas, parentheses etc which need to
    be quoted in in this files, like that "/path/to/fs" name is.
  - you have a comma separated list in a comma separated list, which
    isn't reliably parsable.  I would recommend semi-colons.
    so the above would become.

/path/to/fs hostname(rw,no_root_squash,async,anon_uid=1234,refer=/foo/bar at jupiter:saturn;/home/my\040files at mars:mercury)

An incremental patch to fix that would be great if you are happy with
the different format.

Thanks,
NeilBrown


More information about the NFSv4 mailing list