[PATCH 20/20] nfsd: enforce per-flavor id squashing

Neil Brown neilb at suse.de
Mon Jul 9 21:59:32 EDT 2007


On Thursday July 5, bfields at fieldses.org wrote:
>  
> +static int nfsexp_flags(struct svc_rqst *rqstp, struct svc_export *exp)
> +{
> +	struct exp_flavor_info *f;
> +	struct exp_flavor_info *end = exp->ex_flavors + exp->ex_nflavors;
> +
> +	for (f = exp->ex_flavors; f < end; f++) {
> +		if (f->pseudoflavor == rqstp->rq_flavor)
> +			return f->flags;
> +	}
> +	return exp->ex_flags;
> +
> +}

This looks suspiciously like EX_RDONLY.
What would you think of making this inline, and using it to turn
EX_RDONLY back into a one-liner?

Apart from a few cosmetic changes (e.g. some lines > 80 chars wrapped)
those 20 are fine and will go to Andrew shortly.

Thanks,
NeilBrown


More information about the NFSv4 mailing list