[PATCH 2/8] nfsd4: fix NFSv4 filehandle size units confusion

J. Bruce Fields bfields at fieldses.org
Tue Jun 19 15:28:53 EDT 2007


From: J. Bruce Fields <bfields at citi.umich.edu>

NFS4_FHSIZE is measured in bytes, not 4-byte words, so much more space
than necessary is being allocated for struct nfs4_cb_recall.

I should have wondered why this structure was so much larger than it
needed to be!

Signed-off-by: "J. Bruce Fields" <bfields at citi.umich.edu>
---
 include/linux/nfsd/state.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/nfsd/state.h b/include/linux/nfsd/state.h
index ab5c236..732de9c 100644
--- a/include/linux/nfsd/state.h
+++ b/include/linux/nfsd/state.h
@@ -67,7 +67,7 @@ struct nfs4_cb_recall {
 	int			cbr_trunc;
 	stateid_t		cbr_stateid;
 	u32			cbr_fhlen;
-	u32			cbr_fhval[NFS4_FHSIZE];
+	char			cbr_fhval[NFS4_FHSIZE];
 	struct nfs4_delegation	*cbr_dp;
 };
 
-- 
1.5.2.rc3



More information about the NFSv4 mailing list