[PATCH] crypto: scatterwalk_copychunks() fails to advance through scatterlist

[Herbert Xu]

On Tue, Mar 20, 2007 at 05:17:51PM -0400, J. Bruce Fields wrote:
> 
> By the way, the commit that I believe introduced this regression did two
> or three different things at once--I spent some time staring at it and
> can't say I really understand the change.  That's probably just me!  But
> would it be possible to split up these patches fine enough that people
> inexperienced with this code would have a better chance of understanding
> what's going on?

Good point, I'll make sure they're more granular in future.

> (And did the crypto testing module use to have some tests for buffers
> that were fragmented in odd ways, or was I imagining that?  I'd be happy
> to help come up with some test cases if it'd be useful.)

It does test fragments but it doesn't do it in the way you
suggested.  In particular, the fragments probably won't be
starting off at a page boundary.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt