[PATCH 3/5] spkm3: remove bad kfree, unnecessary export

Bruce Fields bfields at citi.umich.edu
Tue May 1 10:56:27 EDT 2007


From: J. Bruce Fields <bfields at snoopy.citi.umich.edu>

We're kfree()'ing something that was allocated on the stack!

Also remove an unnecessary symbol export while we're at it.

Signed-off-by: J. Bruce Fields <bfields at citi.umich.edu>
---
 net/sunrpc/auth_gss/gss_spkm3_seal.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/net/sunrpc/auth_gss/gss_spkm3_seal.c b/net/sunrpc/auth_gss/gss_spkm3_seal.c
index 36c3bae..3ec9cd3 100644
--- a/net/sunrpc/auth_gss/gss_spkm3_seal.c
+++ b/net/sunrpc/auth_gss/gss_spkm3_seal.c
@@ -123,9 +123,6 @@ spkm3_make_token(struct spkm3_ctx *ctx,
 
 	return  GSS_S_COMPLETE;
 out_err:
-	if (md5cksum.data)
-		kfree(md5cksum.data);
-
 	token->data = NULL;
 	token->len = 0;
 	return GSS_S_FAILURE;
@@ -184,5 +181,3 @@ out:
 
 	return err ? GSS_S_FAILURE : 0;
 }
-
-EXPORT_SYMBOL(make_spkm3_checksum);
-- 
1.5.1.1.107.g7a159



More information about the NFSv4 mailing list