[PATCH 5/5] locks: kill redundant local variable

Bruce Fields bfields at citi.umich.edu
Tue May 1 10:56:29 EDT 2007


From: J. Bruce Fields <bfields at fieldses.org>

There's no need for another variable local to this loop; we can use the
variable (of the same name!) already declared at the top of the function,
and not used till later (at which point it's initialized, so this is safe).

Signed-off-by: J. Bruce Fields <bfields at citi.umich.edu>
---
 fs/locks.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/locks.c b/fs/locks.c
index 52a8100..33e0811 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -827,7 +827,7 @@ static int __posix_lock_file_conf(struct inode *inode, struct file_lock *request
 	lock_kernel();
 	if (request->fl_type != F_UNLCK) {
 		for_each_lock(inode, before) {
-			struct file_lock *fl = *before;
+			fl = *before;
 			if (!IS_POSIX(fl))
 				continue;
 			if (!posix_locks_conflict(request, fl))
-- 
1.5.1.1.107.g7a159



More information about the NFSv4 mailing list