[PATCH 4/4] lockd: nfsd4: use same grace period for lockd and nfsd4

J. Bruce Fields bfields at fieldses.org
Fri May 4 11:44:47 EDT 2007


On Fri, May 04, 2007 at 11:09:11AM +1000, Neil Brown wrote:
> This patch also causes nfsd.ko to export get_nfs4_grace_period, which
> is used by lockd.ko, so you will have a cyclic dependency between
> those two modules - not good.

Ugh, yes, I actually noticed that, and fixed it...

> You could put the get_nfs4_grace_period in nfsd_nlm_ops

...this way, but left the change in the second patch instead of
propogating it back to this one.  Sorry about that.

> or get nfsd to explicitly tell lockd about grace period changes, but
> it all feels rather ugly - the whole grace period concept is rather
> ugly.  I might write about that in a separate email.

Hm.--b.


More information about the NFSv4 mailing list