[PATCH 16/16] nfsd: allow auth_sys nlm on rpcsec_gss exports
J. Bruce Fields
bfields at fieldses.org
Fri May 18 17:28:09 EDT 2007
From: J. Bruce Fields <bfields at citi.umich.edu>
Our clients (like other clients, as far as I know) use only auth_sys for
nlm, even when using rpcsec_gss for the main nfs operations.
Administrators that want to deny non-kerberos-authenticated locking
requests will need to turn off NFS protocol versions less than 4....
Signed-off-by: "J. Bruce Fields" <bfields at citi.umich.edu>
---
fs/nfsd/nfsfh.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
index cebeb01..61ee28e 100644
--- a/fs/nfsd/nfsfh.c
+++ b/fs/nfsd/nfsfh.c
@@ -254,10 +254,16 @@ fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, int access)
if (error)
goto out;
- /* Check security flavor */
- error = check_nfsd_access(exp, rqstp);
- if (error)
- goto out;
+ if (!(access & MAY_LOCK)) {
+ /*
+ * pseudoflavor restrictions are not enforced on NLM,
+ * which clients virtually always use auth_sys for,
+ * even while using RPCSEC_GSS for NFS.
+ */
+ error = check_nfsd_access(exp, rqstp);
+ if (error)
+ goto out;
+ }
/* Finally, check access permissions. */
error = nfsd_permission(rqstp, exp, dentry, access);
--
1.5.2.rc3
More information about the NFSv4
mailing list