[PATCH] fix enc_stateid_sz for nfsd callbacks

[Benny Halevy]

Trond Myklebust wrote:
> On Tue, 2007-05-29 at 18:37 +0300, Benny Halevy wrote:
>> enc_stateid_sz should be given in u32 words units, not bytes.
>> Applies to the pnfs git tree (master and 4.1-sessions) as well as to mainline
>>
>> Signed-off-by: Benny Halevy <bhalevy at panasas.com>
>> ---
>>  fs/nfsd/nfs4callback.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
>> index 97631bf..5a0d983 100644
>> --- a/fs/nfsd/nfs4callback.c
>> +++ b/fs/nfsd/nfs4callback.c
>> @@ -82,7 +82,7 @@ enum nfs_cb_opnum4 {
>>  #define op_enc_sz			1
>>  #define op_dec_sz			2
>>  #define enc_nfs4_fh_sz			(1 + (NFS4_FHSIZE >> 2))
>> -#define enc_stateid_sz			16
>> +#define enc_stateid_sz			(16 >> 2)
> 					  (NFS4_STATEID_SIZE >> 2)
> 
> instead of the naked value '16' would be better

Do you mean that it's better to use '4' rather than (16 >> 2)?