[PATCH] sunrpc: return error if unsupported enctype or cksumtype is encountered

Kevin Coffman kwc at citi.umich.edu
Mon Oct 29 13:36:36 EDT 2007


On 10/29/07, J. Bruce Fields <bfields at fieldses.org> wrote:
> On Mon, Oct 29, 2007 at 01:03:27PM -0400, Kevin Coffman wrote:

> I'm confused about just this one chunk of your patch:
>
> > --- a/net/sunrpc/auth_gss/auth_gss.c
> > +++ b/net/sunrpc/auth_gss/auth_gss.c
> > @@ -540,7 +540,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
> >       p = gss_fill_context(p, end, ctx, gss_msg->auth->mech);
> >       if (IS_ERR(p)) {
> >               err = PTR_ERR(p);
> > -             gss_msg->msg.errno = (err == -EACCES) ? -EACCES : -EAGAIN;
> > +             gss_msg->msg.errno = (err == -EAGAIN) ? -EAGAIN : -EACCES;
> >               goto err_release_msg;
> >       }
> >       gss_msg->ctx = gss_get_ctx(ctx);
>
> Is that related to this problem, or is that a separate issue?
>
> --b.

Sorry.  Yes, I think it is a separate issue.  I should have made it a
separate patch.   I can separate them and resend if you'd like.

gss_fill_context() can return a number of errors such as EFAULT.  It
seems that they should all be translated to EACCES unless EAGAIN is
returned.


More information about the NFSv4 mailing list