[PATCH 24/27] NFS: Use local caching [try #2]

David Howells dhowells at redhat.com
Thu Jan 31 18:29:17 EST 2008


Chuck Lever <chuck.lever at oracle.com> wrote:

> >>> +struct nfs_fh_auxdata {
> >>> +	struct timespec	i_mtime;
> >>> +	struct timespec	i_ctime;
> >>> +	loff_t		i_size;
> >>> +};
> >>
> >> It might be useful to explain here why you need to supplement the
> >> mtime, ctime, and size fields that already exist in an NFS inode.
> >
> > Supplement?  I don't understand.
> 
> Why is it necessary to add additional mtime, ctime and size fields for NFS
> inodes?  Similar metadata is already stored in nfsi.

Yes, but this is the data that's stored in the cache on disk, not what's
stored in the NFS inode struct in RAM.

I'll add some more comments to the code to make this clearer.

David


More information about the NFSv4 mailing list