Oops in NFSv4 server in 2.6.23.17

[Lukas Hejtmanek]

On Fri, Mar 14, 2008 at 03:33:50PM -0400, J. Bruce Fields wrote:
> OK, yes, I think so.  Could you confirm whether this fixes it?

I will test it on Monday as I cannot reboot the machine right now.

Just a quick review - isn't the cache_get() call needed also on the line 185 in
the same file?
 
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index 1eb771d..3e6b3f4 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -232,6 +232,7 @@ fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, int access)
>  		fhp->fh_dentry = dentry;
>  		fhp->fh_export = exp;
>  		nfsd_nr_verified++;
> +		cache_get(&exp->h);
>  	} else {
>  		/*
>  		 * just rechecking permissions
> @@ -241,6 +242,7 @@ fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, int access)
>  		dprintk("nfsd: fh_verify - just checking\n");
>  		dentry = fhp->fh_dentry;
>  		exp = fhp->fh_export;
> +		cache_get(&exp->h);
>  		/*
>  		 * Set user creds for this exportpoint; necessary even
>  		 * in the "just checking" case because this may be a
> @@ -252,8 +254,6 @@ fh_verify(struct svc_rqst *rqstp, struct svc_fh *fhp, int type, int access)
>  		if (error)
>  			goto out;
>  	}
> -	cache_get(&exp->h);
> -
>  
>  	error = nfsd_mode_check(rqstp, dentry->d_inode->i_mode, type);
>  	if (error)

-- 
Lukáš Hejtmánek