[pnfs] [PATCH] Increase maximum buffer size for layouts to 4 KB

Benny Halevy bhalevy at panasas.com
Tue Nov 28 09:34:17 EST 2006


William A. (Andy) Adamson wrote:
> hi benny
> 
> should be ok.
> are you expecting to have a large number of 4KB layouts? are you 
> combining a bunch of layout ranges in the 4KB layout return?

not necessarily...
we just have big data structures.
are we going to keep this static?
If so I will check what;s the largest size we can anticipate



> 
> -->Andy
> 
> On 11/28/06, *Benny Halevy* <bhalevy at panasas.com 
> <mailto:bhalevy at panasas.com>> wrote:
> 
>     We need a bigger buffer size for our layouts.  Since we're
>     still using a statically sized buffer, is it ok with everybody
>     to increase its size to 4 KB as in the patch below?
> 
>     Benny
> 
>     Increase maximum buffer size for layouts to 4 KB.
> 
>     Signed-off-by: Benny Halevy bhalevy at panasas.com
>     <mailto:bhalevy at panasas.com>
> 
>     ==== //depot/pub/pnfs/include/linux/pnfs_xdr.h#1 -
>     /home/bhalevy/p4.local/pub-pnfs/include/linux/pnfs_xdr.h ====
>     diff -Npu /tmp/tmp.12239.0
>     /home/bhalevy/p4.local/pub-pnfs/include/linux/pnfs_xdr.h -L
>     a/include/linux/pnfs_xdr.h -L b/include/linux/pnfs_xdr.h
>     --- a/include/linux/pnfs_xdr.h
>     +++ b/include/linux/pnfs_xdr.h
>     @@ -14,7 +14,7 @@
> 
>       #include <linux/nfs4.h>
> 
>     -#define PNFS_LAYOUT_MAXSIZE 1024
>     +#define PNFS_LAYOUT_MAXSIZE 4096
>       #define PNFS_MAX_NUM_LAYOUT_TYPES 2
> 
>       enum layoutreturn_type {
>     _______________________________________________
>     pNFS mailing list
>     pNFS at linux-nfs.org <mailto:pNFS at linux-nfs.org>
>     http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
> 
> 



More information about the pNFS mailing list