[pnfs] Re: [nfsv4] Bakeathon and NFSv4.1 testing

[William A.(Andy) Adamson]

hi lisa

so we've  moved our Linux pnfs client and server to  
http://www.nfsv4-editor.org/draft05/nfs41_prot.x with a couple of differences. 
could you please comment on how your xdr compares?

1) draft05 incorrectly declares fattr4_fs_layout_type and fattr4_layout_type 
as a single layouttype4 - these should both be opaque.

typedef layouttype4	fattr4_fs_layout_type;
typedef layouttype4	fattr4_layout_type;

should be:
typedef layouttype4<>	fattr4_fs_layout_types;
typedef layouttype4<>	fattr4_layout_types;

we've only implemented fattr4_fs_layout_types and we've implemented the opaque 
list.


2) we currently have not moved to the 3-word getattr bitmap required to hold 
the 63 plus attributes. have you?

3) we have left the clientid in layoutget - i suspect you have removed it :)

4) we don't use the temp definition of newsize4: 

/*
 * TEMPORARY definition
 */
typedef uint64_t newsize4;

struct LAYOUTCOMMIT4resok {
	newsize4                 locr_newsize;
};

instead we use

union newtime4 switch (bool timechanged) {
case TRUE:
	nfstime4	   nt_time;
case FALSE:
	void;
};


thanks!

-->Andy


> William A.(Andy) Adamson wrote:
> 
> >hi lisa
> >
> >we just had our linux pnfs client phone telecon, and we've agreed to 
> >investigate moving to http://www.nfsv4-editor.org/draft05/nfs41_prot.x. what 
> >we have now is a hodge-podge of pnfs features and xdr. we'll know early next 
> >week if we will move to the above nfs41_prot.x - it looks good.
> >
> >  
> >
> Great!  Please keep us informed with what you decide.
>