[pnfs] Server sessions slot table patches

[Iyer, Rahul]

Hi Andy,
The exchange_id patches look ok. As for the slot table patches, I had a
couple of comments:

How fast is crc32c? Since it's a crypto digest/CRC calculator (I don't
know what it is), is it slow? We don't wasn't this being a bottleneck.
We need a reasonable hash with a decent spread, not necessarily a secure
one. 

Also, I'd suggest making the has table size prime... It helps the spread
with the modulo.

In patch 0007 of the slot table, in nfsd4_sequence, the KERN_EMERG could
be KERN_ERROR or KERN_NOTICE (I know I'm responsible for the EMERG ;) )

Regards
Rahul


> -----Original Message-----
> From: William A. (Andy) Adamson [mailto:andros at citi.umich.edu] 
> Sent: Tuesday, April 03, 2007 6:43 AM
> To: pnfs at linux-nfs.org
> Subject: [pnfs] Server sessions slot table patches
> 
> hi
> 
> here are 9 patches that implement the server slot table 
> management. there is not DRC yet, but this code has been 
> developed with the DRC in mind. This code almost passes the 
> connectathon tests on the 4.1-sessions branch with the client 
> patches i just sent out. 
> 
> it fails the general connectathon tests with an 
> NFS4ERR_SEQ_MISORDERED. i note that the client mostly uses 
> slot 0, and occasionally uses slot 1. the slot 1 sequence is 
> out of order - i don't know if it is the client or server. 
> 
> please review the patches...
> 
> thanks
> 
> -->Andy
> 
>