[pnfs] 4.1-sessions branch and exchange_id

[Benny Halevy]

Andy, in patch 0001-Update-client-exchange_id-structures-to-minorversion.patch
+struct nfs_impl_id4 {
+	u32		domain_len;
+	char *		domain;
+	u32		name_len;
+	char *		name;
+	struct timespec	date;

=> struct nfstime4 date;
according to i-d. the difference is that the seconds field is 64 bit wide

+};

and correspondingly,
in 0003-Update-nfs4_proc_exchange_id-to-minorversion1-10.patch:
+	args.impl_id.date.tv_sec = htonl((u32)clp->cl_boot_time.tv_sec);
+	args.impl_id.date.tv_nsec = htonl((u32)clp->cl_boot_time.tv_nsec);
=> args.impl_id.date.tv_sec = clp->cl_boot_time.tv_sec;
=> args.impl_id.date.tv_nsec = clp->cl_boot_time.tv_nsec;

No need to store in net order here since this is done later in encode_exchange_id()

in 0004-Update-exchange_id-encode-XDR-to-minorversion1-10.patch

+	WRITE32(args->impl_id.date.tv_sec);
=> WRITE64(args->impl_id.date.tv_sec);

Benny

William A. (Andy) Adamson wrote:
> hi
> 
> i have a set of slot table server patches that i will put up today for
> review. but first, we have a slight problem with exchange_id
> 
> 1) the patch from marc that updated exchange_id to
> draft-ietf-nfsv4-minorversion1-10 was applied to the master (pnfs) branch.
> it needs to be applied to the 4.1-sessions branch and then merged with the
> master.
> 
> 2) the updated exchange_id code that is currently in the master branch has a
> couple of issues - i'm not sure the latest code where marc responded to
> comments actually got into the master.
> 
> so - i want to apply a 'good' version of the exchange_id update to latest
> dratf patch to the 4.1-sessions branch. i've included a set of 4 small
> patches that i think do the job. could you please review?
> 
> the 5th patch applies a fix to the sessions branch that is also in the
> master branch - can't run without it...
> 
> thanks
> 
> -->Andy
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs