[pnfs] [PATCH 4/5] Shut down the v4 style callback server for v4.1

[J. Bruce Fields]

On Mon, Apr 16, 2007 at 09:06:52PM -0700, iyer at netapp.com wrote:
> From: Rahul Iyer <iyer at netapp.com>
> 
> This patch shuts down the v4.1 server in case the mount is a v4.1 mount. If
> it's a v4 mount, nothing changes.
> 
> Signed-off-by: Rahul Iyer <iyer at netapp.com>
> ---
>  fs/nfs/super.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index 89eb564..3411ea1 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -1270,8 +1270,17 @@ static int nfs4_fill_super(struct super_block *sb, struct nfs4_mount_data *data,
>                                  printk(KERN_EMERG "Couldn't mount using minorversion %d\n", i);
>                                  rpc_shutdown_client(server->client);
>                          }
> -			else
> +			else {

Extremely minor nit--note that standard kernel style is

				...
			} else {
				...

and it'll save some tedium later if we try to stick to that from the
beginning.

Also, the indentation in the previous if (IS_ERR(server->client)) clause
is weird.  And does it really need to create a new rpc client each time
through this loop?  (Isn't that part minor version-independent?)

--b.