[pnfs] [PATCH 3/5] Added v4.1 defines to the Kconfig

[Benny Halevy]

Iyer, Rahul wrote:
> So Benny,
> Was this patch acceptable too? I'll make a separate one and send it to
> Andy if no one has an objection (I assume the server guys will fix the
> server config sometime)
>   
I am not sure we should wait on the server guys to do the right thing.
This should be separated into two patches.
One should add "select RPCSEC_GSS_KRB5" to config NFSD_V4
(and should be sent to the server guy for approval to go upstream)
The other defines config NFS_V4_1and NFSD_V4_1 and make them depend on
the respective NFS*_V4 config items.

It looks like the order between them doesn't matter.

Benny

> Regards
> Rahul
>
>
>   
>> -----Original Message-----
>> From: Benny Halevy [mailto:bhalevy at panasas.com] 
>> Sent: Tuesday, April 17, 2007 6:22 AM
>> To: Iyer, Rahul
>> Cc: pnfs at linux-nfs.org
>> Subject: Re: [pnfs] [PATCH 3/5] Added v4.1 defines to the Kconfig
>>
>> iyer at netapp.com wrote:
>>     
>>> From: Rahul Iyer <iyer at netapp.com>
>>>
>>> Added NFS_V4_1 and NFSD_V4_1 to fs/Kconfig
>>>
>>> Signed-off-by: Rahul Iyer <iyer at netapp.com>
>>> ---
>>>  fs/Kconfig |   23 +++++++++++++++++++++++
>>>  1 files changed, 23 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/fs/Kconfig b/fs/Kconfig
>>> index 3f00a9f..7d57917 100644
>>> --- a/fs/Kconfig
>>> +++ b/fs/Kconfig
>>> @@ -1470,6 +1470,19 @@ config NFS_V4
>>>  
>>>  	  If unsure, say N.
>>>  
>>> +config NFS_V4_1
>>> +	bool "Provide NFSv4.1 client support (EXPERIMENTAL)"
>>> +	depends on NFS_FS && NFS_V4 && EXPERIMENTAL
>>> +	select RPCSEC_GSS_KRB5
>>> +	help
>>> +	  Say Y here if you want your NFS client to be able to 
>>>       
>> speak the newer
>>     
>>> +	  version 4 minorversion 1 of the NFS protocol.
>>> +
>>> +	  Note: Requires auxiliary userspace daemons which may 
>>>       
>> be found on
>>     
>>> +		http://www.citi.umich.edu/projects/nfsv4/
>>> +
>>> +	  If unsure, say N.
>>> +
>>>  config NFS_DIRECTIO
>>>  	bool "Allow direct I/O on NFS files (EXPERIMENTAL)"
>>>  	depends on NFS_FS && EXPERIMENTAL
>>> @@ -1558,6 +1571,16 @@ config NFSD_V4
>>>  	  should only be used if you are interested in helping 
>>>       
>> to test NFSv4.
>>     
>>>  	  If unsure, say N.
>>>  
>>> +config NFSD_V4_1
>>> +	bool "Provide NFSv4.1 server support (EXPERIMENTAL)"
>>> +	depends on NFSD_V3 && NFSD_V4 && EXPERIMENTAL
>>>       
>> Why don't NFS_V4{,_1} select RPCSEC_GSS_KRB5 like the nfs client?
>> According to the spec the nfsd MUST implement RPCSEC_GSS 
>> (integrity, auth, and privacy), over Kerberos V5, SPKM-3, and 
>> LIPKEY :).
>>
>>
>>     
>>> +	help
>>> +	  If you would like to include the NFSv4.1 server as 
>>>       
>> well as the NFSv2
>>     
>>> +	  NFSv3 and NFSv4 servers, say Y here.  This feature is 
>>>       
>> experimental, 
>>     
>>> +	  and should only be used if you are interested in 
>>>       
>> helping to test 
>>     
>>> +	  NFSv4.1.
>>> +	  If unsure, say N.
>>> +
>>>  config NFSD_TCP
>>>  	bool "Provide NFS server over TCP support"
>>>  	depends on NFSD
>>>