[pnfs] [PATCH] move shared nfs41 types to include/linux/nfs4.h

[Benny Halevy]

William A. (Andy) Adamson wrote:
> On 4/17/07, Benny Halevy <bhalevy at panasas.com> wrote:
>> Benny Halevy wrote:
>>> @@ -2333,7 +2334,8 @@ set_curr_ses:
>>>       /* Set current_session. hold reference until done processing
>> compound.
>>>        * nfs41_put_session called only if cs_slot is set
>>>        */
>>> -     memcpy(c_ses->cs_sid, &seq->sessionid, sizeof(sessionid_t));
>>> +     memcpy(&c_ses->cs_sid, &seq->sessionid, sizeof(c_ses->cs_sid));
>>> +     COMPILE_BUG_ON(sizeof(c_ses->cs_sid) == sizeof(seq->sessionid));
>> oops, make that BUG_ON() as COMPILE_BUG_ON is not available yet in
>> 2.6.18.3
> 
> 
> 
> since both c_ses->cs_sid and  seq->sessionid are now typed as
> nfs4_sessionid, why do we need to have a BUG_ON the size comparison?

the patch changes cs_sid's type to nfsd_sessionid_t