[pnfs] [PATCH 13/20] 2.6-latest pnfs client pnfs_try_to_read

Benny Halevy bhalevy at panasas.com
Sun Dec 2 04:10:55 EST 2007


On Dec. 02, 2007, 9:42 +0200, Dean Hildebrand <seattleplus at gmail.com> wrote:
> I notice this patch moves nfs_execute_read and nfs_initiate_read to the 
> top.  My suggestion would be to use forward declarations instead.  This 
> will help avoid possible errors in moving the code forward if either of 
> those functions changes. 
> 
> If we can avoid any patches that simply move functions around the easier 
> it will be to see what each patch truly does.
> Dean
> 

I think that's a good point.
Moving code that exists in the mainline trees around makes it harder to
merge our changes with the mainline code, in both directions.
Let's try keep this as an option only to code present only in our tree.

Benny


More information about the pNFS mailing list