[pnfs] [PATCH 13/20] 2.6-latest pnfs client pnfs_try_to_read

[William A. (Andy) Adamson]

On 12/2/07, Benny Halevy <bhalevy at panasas.com> wrote:
>
> On Dec. 02, 2007, 9:42 +0200, Dean Hildebrand <seattleplus at gmail.com>
> wrote:
> > I notice this patch moves nfs_execute_read and nfs_initiate_read to the
> > top.  My suggestion would be to use forward declarations instead.  This
> > will help avoid possible errors in moving the code forward if either of
> > those functions changes.
> >
> > If we can avoid any patches that simply move functions around the easier
> > it will be to see what each patch truly does.
> > Dean
> >
>
> I think that's a good point.
> Moving code that exists in the mainline trees around makes it harder to
> merge our changes with the mainline code, in both directions.
> Let's try keep this as an option only to code present only in our tree.



agreed. note that there is no nfs_initiate_read() in the mainline kernel,
this was ported forward
in the linux-pnfs-2.6-latest tree prior to my patches. i guess i could start
with a patch that reverts
fs/nfs/read.c to the mainline kernel, and then do as you suggest.

should this go under the heading of

"don't change too much at once, just port forward first" ?

-->Andy

Benny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://linux-nfs.org/pipermail/pnfs/attachments/20071203/d3984b41/attachment-0001.htm