[pnfs] CVS: nfsv4

[Iyer, Rahul]

Yes, I realize this. In case the session expires, the next operation
that follows will need a sequence op. This will cause the code to drop
into reclaimer and setup a session again.
Regards
Rahul
 

> -----Original Message-----
> From: William A. (Andy) Adamson [mailto:andros at citi.umich.edu] 
> Sent: Monday, January 29, 2007 9:45 AM
> To: Iyer, Rahul
> Cc: pnfs at linux-nfs.org
> Subject: Re: [pnfs] CVS: nfsv4
> 
> hi rahul
> 
> 
> On 1/29/07, Iyer, Rahul <Rahul.Iyer at netapp.com > wrote:
> 
> 	So, the reason I used nfs4_get_renew_cred() was that I 
> didn't want to
> 	send sequence always. If there are no open files, then 
> that's fine... We
> 	do not send a sequence and let the clientid (and the 
> associated session) 
> 	expire.
> 
> 
> you don't have a choice. if you declare minorversion1, you 
> must esablish a session,  and  you must send a sequence operation.
> 
> 
> section 2.9.1 draft-ietf-nfsv4-minorversion1-08: 
> 
> When the NFSv4 server processes a COMPOUND with the minor version set
>    to 1, it expects a different set of operations than it does for
>    NFSv4.0.  One operation it expects is the SEQUENCE operation, which
> 
> 
>    is required for every COMPOUND that operates over an established
>    session.
> 
> 
> 
> 	We can set the session up as and when needed again. AFAICS this
> 	approach sure beats littering the network with needless traffic.
> 
> 	About the null pointer, what was NULL? 
> Nfs41_proc_sequence() takes 3
> 	arguments - a session pointer, a nfs41_sequence_res 
> pointer and a status
> 	int. Which was NULL again and what was the test case?
> 
> 	Regards
> 	Rahul
> 	P.S: I have some uncommitted code... We have all pNFS 
> ops except for 
> 	LAYOUTCOMMIT and LAYOUTRETURN working... We should be 
> able to finish
> 	that off on Monday and I'll commit it in one go.
> 	
> 	
> 	> -----Original Message-----
> 	> From: William Andros Adamson [mailto: 
> andros at citi.umich.edu <mailto:andros at citi.umich.edu> ]
> 	> Sent: Saturday, January 27, 2007 2:48 PM
> 	> To: pnfs at linux-nfs.org
> 	> Subject: [pnfs] CVS: nfsv4
> 	>
> 	> CVSROOT:      /cvs
> 	> Module name:  nfsv4 
> 	> Changes by:   andros at citi.umich.edu   2007/01/27 17:48:03
> 	>
> 	> Modified files:
> 	>       cvs/pnfs/fs/nfs: nfs4proc.c nfs4renewd.c
> 	>
> 	> Log message: 
> 	> nfs4_get_renew_cred() searches the list of stateowners for a
> 	> given nfs4_client and returns the first credential it finds.
> 	> this works for OP_RENEW which is only needed when state has
> 	> been established. 
> 	>
> 	> sessions changes the renew strategy: OP_SEQUENCE is sent with
> 	> every RPC, and a OP_RENEW call must be sent caveat lease_time
> 	> even when no OPEN state has been established.
> 	>
> 	> if nfs4_get_renew_cred() fails to find a credential, 
> create on with 
> 	> rpcauth_lookupcred() for the renew call under sessions.
> 	>
> 	> nfs41_proc_sequence_done() can have a NULL data - at least i
> 	> hit it in my debugging....
> 	>
> 	> _______________________________________________ 
> 	> pNFS mailing list
> 	> pNFS at linux-nfs.org
> 	> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs 
> <http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs> 
> 	>
> 	
> 	
> 
> 
>