[pnfs] Resend: [PATCH] debug print ntohl(status) in nfs client callback xdr code

Trond Myklebust trond.myklebust at fys.uio.no
Fri Jul 13 19:34:26 EDT 2007


On Thu, 2007-07-12 at 19:44 +0300, Benny Halevy wrote:
> 
> -------- Original Message --------
> Subject: [PATCH] debug print ntohl(status) in nfs client callback xdr code
> Date: Mon,  9 Jul 2007 15:51:50 +0300
> From: Benny Halevy <bhalevy at panasas.com>
> To: pnfs at linux-pnfs.org
> CC: Benny Halevy <bhalevy at panasas.com>
> 
> for sessions branch

Why not send it to me now?

Trond

> Signed-off-by: Benny Halevy <bhalevy at panasas.com>
> 
> ---
>  fs/nfs/callback_xdr.c |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c
> index 2489bee..b2460d5 100644
> --- a/fs/nfs/callback_xdr.c
> +++ b/fs/nfs/callback_xdr.c
> @@ -192,7 +192,7 @@ static unsigned decode_getattr_args(struct svc_rqst *rqstp, struct xdr_stream *x
>  	args->addr = &rqstp->rq_addr;
>  	status = decode_bitmap(xdr, args->bitmap);
>  out:
> -	dprintk("%s: exit with status = %d\n", __FUNCTION__, status);
> +	dprintk("%s: exit with status = %d\n", __FUNCTION__, ntohl(status));
>  	return status;
>  }
>  
> @@ -213,7 +213,7 @@ static unsigned decode_recall_args(struct svc_rqst *rqstp, struct xdr_stream *xd
>  	args->truncate = ntohl(*p);
>  	status = decode_fh(xdr, &args->fh);
>  out:
> -	dprintk("%s: exit with status = %d\n", __FUNCTION__, status);
> +	dprintk("%s: exit with status = %d\n", __FUNCTION__, ntohl(status));
>  	return status;
>  }
>  
> @@ -299,7 +299,7 @@ static unsigned decode_cb_sequence_args(struct svc_rqst *rqstp,
>  		args->cbs_highestslotid, args->cbs_cachethis,
>  		args->cbs_nrclists);
>  out:
> -	dprintk("%s: exit with status = %d\n", __FUNCTION__, status);
> +	dprintk("%s: exit with status = %d\n", __FUNCTION__, ntohl(status));
>  	return status;
>  
>  out_free:
> @@ -455,7 +455,7 @@ static unsigned encode_getattr_res(struct svc_rqst *rqstp, struct xdr_stream *xd
>  	status = encode_attr_mtime(xdr, res->bitmap, &res->mtime);
>  	*savep = htonl((unsigned int)((char *)xdr->p - (char *)(savep+1)));
>  out:
> -	dprintk("%s: exit with status = %d\n", __FUNCTION__, status);
> +	dprintk("%s: exit with status = %d\n", __FUNCTION__, ntohl(status));
>  	return status;
>  }
>  
> @@ -476,7 +476,7 @@ static unsigned encode_cb_sequence_res(struct svc_rqst *rqstp,
>  	/* FIXME: implement cb_sequenceres */
>  	memset(p, 0, 8 * sizeof(uint32_t));
>  out:
> -	dprintk("%s: exit with status = %d\n", __FUNCTION__, status);
> +	dprintk("%s: exit with status = %d\n", __FUNCTION__, ntohl(status));
>  	return status;
>  }
>  
> @@ -556,7 +556,7 @@ out:
>  		status = res;
>  	if (op->encode_res != NULL && status == 0)
>  		status = op->encode_res(rqstp, xdr_out, resp);
> -	dprintk("%s: done, status = %d\n", __FUNCTION__, status);
> +	dprintk("%s: done, status = %d\n", __FUNCTION__, ntohl(status));
>  	return status;
>  
>  out_illegal:
> @@ -602,7 +602,7 @@ static int nfs4_callback_compound(struct svc_rqst *rqstp, void *argp, void *resp
>  	}
>  	*hdr_res.status = status;
>  	*hdr_res.nops = htonl(nops);
> -	dprintk("%s: done, status = %u\n", __FUNCTION__, status);
> +	dprintk("%s: done, status = %u\n", __FUNCTION__, ntohl(status));
>  	return rpc_success;
>  }
>  
> -- 
> 1.5.2.86.g99b5
> 
> 



More information about the pNFS mailing list