[pnfs] [PATCH] Fix comparison of verifiers in the client ID

Benny Halevy bhalevy at panasas.com
Sun Jul 22 10:08:20 EDT 2007


How about renaming cmp_verf and cmp_clid to same_* (like same_name above it)
so they wouldn't be so confusing? (having traditional *cmp functions in mind)

Benny

Ricardo Labiaga wrote:
> Fixes problem with server incorrectly returning NFS4ERR_CLID_INUSE.
> 
> Signed-off-by: Ricardo Labiaga <ricardo.labiaga at netapp.com>
> ---
>  fs/nfsd/nfs4state.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 643ad9b..c2c5b8f 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1177,7 +1177,7 @@ int nfsd4_exchange_id(struct svc_rqst *rqstp,
> struct nfsd4_exchange_id *clid)
>                          goto out;
>                  }
> 
> -                if (cmp_verf(&verf, &conf->cl_verifier)) {
> +                if (!cmp_verf(&verf, &conf->cl_verifier)) {
>                          /* Client reboot: destroy old state */
>                          expire_client(conf);
>                         goto out_new;



More information about the pNFS mailing list