[pnfs] Wireshark patch for draft 10

[Benny Halevy]

So what's the final word on this?
Can you please send an updated patch, preferably to a plain vanilla
wireshark release?

Benny

William A. (Andy) Adamson wrote:
> On 5/31/07, Iyer, Rahul <Rahul.Iyer at netapp.com> wrote:
>>
>>
>>> -----Original Message-----
>>> From: William A. (Andy) Adamson [mailto:andros at citi.umich.edu]
>>> Sent: Thursday, May 31, 2007 7:24 AM
>>> To: Iyer, Rahul
>>> Cc: pnfs at linux-nfs.org
>>> Subject: Re: [pnfs] Wireshark patch for draft 10
>>>
>>>
>>>
>>> On 5/30/07, Iyer, Rahul <Rahul.Iyer at netapp.com> wrote:
>>>
>>>       Hi guys,
>>>       Attached here is a patch for the draft 10 xdr changes.
>>> It's a patch for epan/dissectors/packet-nfs.c.
>>>
>>> \
>>> thanks rahul.
>>>
>>>
>>>
>>>       cd <wireshark_dir>
>>>       cd epan/dissectors
>>>       patch -p1 < ethereal_draft10-patch.txt
>>>
>>>       This should apply cleanly
>>>
>>>
>>> it did not apply cleanly over garths packet-nfs.c on wireshark-0.99.5.
>>>
>> That's really odd!
> 
> 
> your patch uses hf_nfs_sequenceid4 which is not in the packet-nfs.c that i
> have... whatever, it was easy to fix.
> 
>> also, the OP_SEQUENCE hf_nfs_cachethis4 was not dissected in
>>> dissect_nfs_resop4.
>>>
>> I don't believe there's a cachethis4 in the result of SEQUENCE. At least
>> http://www.nfsv4-editor.org/draft-10/draft-ietf-nfsv4-minorversion1-10-l
>> n.txt doesn't seem to say so...
> 
> 
> 
> ah - sorry, you 're correct... it was the hf_nfs_exch_id_flags4 in the
> exchange_id4 return that was missing...
> 
> -->Andy
> 
> 
> Regards
>> Rahu
> 
> 17.46.3
> 
> 
> 
> 
> 
>> i've attached the packet_nfs.c that works for me.
>>> -->Andy
>>>
>>>
>>>
>>>       Thanks
>>>       regards
>>>       Rahul
>>>       P.S: the flags are currently a Hex value. Will make
>>> them a subtree next week.
>>>
>>>
>>>       _______________________________________________
>>>       pNFS mailing list
>>>       pNFS at linux-nfs.org
>>>       http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>>> <http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs>
>>>
>>>
>>>
>>>
>>>
>>
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs