[pnfs] BUG in nfs4filelayoutdev:device_create function

[Tigran Mkrtchyan]

Halevy, Benny wrote:
> Well not every missing feature is a bug...
> I'd settle on a design bug :)

Agreed.

> 
> Any chance you can draft a solution, try it in your environment,
> and send a patch?
> 


I will try to.

Regards,
	Tigran.

> Benny
> 
> 
> -----Original Message-----
> From: pnfs-bounces at linux-nfs.org on behalf of Tigran Mkrtchyan
> Sent: Wed 2007-06-06 14:01
> To: pnfs at linux-nfs.org
> Subject: [pnfs] BUG in nfs4filelayoutdev:device_create function
>  
> 
> Hi,
> 
> 
> from my point of view it's a bug:
> 
> device_create creates a new connection to data server if it's not exist 
> yet. To perform this check only client IP is used, which prevents to 
> have MDS and DS on the same host listening different ports.
> 
> ______
> 	sin.sin_family = AF_INET;
> 	sin.sin_addr.s_addr = dev->ip_addr;
> 	sin.sin_port = dev->port;
> 
> 	clp = server->rpc_ops->get_client(&sin.sin_addr);
> 	if (!clp) {
> 		err = PTR_ERR(clp);
> 		dprintk("%s: failed to create NFS4 client err %d\n",
> 			__FUNCTION__, err);
> 		goto out;
> 	}
> 
> 	dprintk("device_create: dev_id=%u, ip=%x, port=%hu, rpcclient %p\n",
> 		dev->dev_id, ntohl(dev->ip_addr), ntohs(dev->port), clp->cl_rpcclient);
> 
> _______
> 
> Regards,
> 	Tigran:
> 
> 
> ________________________________________________________________________
> Tigran Mkrtchyan                               DESY, IT,
> tigran.mkrtchyan at desy.de                       Notkestrasse 85,
> Tel: + 49 40 89983946                          Hamburg 22607,
> Fax: + 49 40 89984429                          Germany.
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
> 


-- 
________________________________________________________________________
Tigran Mkrtchyan                               DESY, IT,
tigran.mkrtchyan at desy.de                       Notkestrasse 85,
Tel: + 49 40 89983946                          Hamburg 22607,
Fax: + 49 40 89984429                          Germany.