[pnfs] [PATCH] update file layout for draft 10 on the server side
Ricardo Labiaga
ricardo.labiaga at netapp.com
Thu Jun 7 03:28:01 EDT 2007
Hi Marc, Andy,
This update causes the XDR stream to contain 4 extra bytes of garbage
when 2 or more Data Servers are included in the layout. The client
then incorrectly decodes a bogus device id.
The fix is to reduce the length by 4. I'll send the patch separately.
- ricardo
Marc Eshel wrote:
>
> Andy, please update the git with the corresponding fix on the server side.
> Thanks, Marc.
>
> > From: Marc Eshel <eshel at almaden.ibm.com>
> >
> >
> > ---
> >
> > fs/nfsd/nfs4filelayoutxdr.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/nfsd/nfs4filelayoutxdr.c b/fs/nfsd/nfs4filelayoutxdr.c
> > index 68ea45d..2d0daad 100644
> > --- a/fs/nfsd/nfs4filelayoutxdr.c
> > +++ b/fs/nfsd/nfs4filelayoutxdr.c
> > @@ -92,7 +92,6 @@ filelayout_encode_layoutlist_item(u32 *p
> > len = 16 + fhlen;
> > if (p + XDR_QUADLEN(len) > end)
> > return -ENOMEM;
> > - WRITE32(item->dev_layout_type);
> > WRITE32(item->dev_id);
> > WRITE32(item->dev_index);
> > WRITE32(fhlen);
> > _______________________________________________
> > pNFS mailing list
> > pNFS at linux-nfs.org
> > http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
More information about the pNFS
mailing list