[pnfs] [PATCH] update exchange id reply to draft 9
J. Bruce Fields
bfields at fieldses.org
Thu Mar 8 10:28:56 EST 2007
On Thu, Mar 08, 2007 at 10:36:35AM +0200, Benny Halevy wrote:
> Marc, this is not strictly related to this patch but why are
> we defining struct nfstime4 and using it in struct nfs_impl_id4?
> why not just use struct timespec in core?
> Also, I think that the following initialization should keep the time value
> in host order and not net order as encode_exchange_id() takes care of that.
> + args.impl_id.date.seconds = htonl((u32)clp->cl_boot_time.tv_sec);
> + args.impl_id.date.nseconds = htonl((u32)clp->cl_boot_time.tv_nsec);
If we just zero out the exchange id and throw it away on receipt then
there's no need to worry about any of this, since we can remove the
structure completely; all the zeroing and throwing will be done entirely
at the xdr level.
--b.
More information about the pNFS
mailing list