[pnfs] [PATCH] update exchange id reply to draft 9

J. Bruce Fields bfields at fieldses.org
Thu Mar 8 10:32:18 EST 2007


On Thu, Mar 08, 2007 at 12:03:51PM +0200, Benny Halevy wrote:
> Marc Eshel wrote:
> > -                RESERVE_SPACE(8 + 4 + 8 + 4 + major_id_sz + 4 + server_scope_sz);
> > +		RESERVE_SPACE(8+4+4+8+4+major_id_sz+4+server_scope_sz);
> 
> we should replace all leading spaces with tabs at some point...

Note the earlier we can do that the better, since those sorts of changes
really clutter up the diffs (which I guess is the real reason for having
a standard about it).  In a similar vein, we should get in the habit of
checking patches for any additions of trailing whitespace: something
like /^\+.*\s+$/, depending on regular expression flavor, should do the
job.

--b.


More information about the pNFS mailing list