[pnfs] [PATCH] update exchange id reply to draft 9

J. Bruce Fields bfields at fieldses.org
Thu Mar 8 11:43:15 EST 2007


On Thu, Mar 08, 2007 at 08:21:09AM -0800, Marc Eshel wrote:
> OK, if we all agree that we want to completely ignore implementation id 
> that I will redo the patch. Bruc, READ_BUF doesn't move p forward maybe 
> there some other macro to do it but for now I will use "p += 
> XDR_QUADLEN(len)".

OK.  The assignment at the top of READ_BUF may all you need if don't
need p updated until the next READ_BUF.

	#define READ_BUF(nbytes)  do { \
	        p = xdr_inline_decode(xdr, nbytes); \

> I see that much of the new code was not tabs and I 
> change only new line, should we add tabs any time we see it missing even 
> for unrelated fix ?

Some time we'll have to go back through the older 4.1 work and fix that
too, but for now I think for now each new patch should change whitespace
on lines that the patch is already touching.

--b.


More information about the pNFS mailing list