On Fri, May 04, 2007 at 10:04:54AM +0300, Benny Halevy wrote: > would you rather define it as u8 fh_fhval[NFS4_FHSIZE] or > u32 fh_fhval[NFS4_FHSIZE/sizeof(u32)]? (same for cbr_fhval) The former seems simpler, but I don't see any other reason to care either way.... --b.