[pnfs] Some cleanups/bugfixes to the code

William A. (Andy) Adamson andros at citi.umich.edu
Thu May 17 11:30:51 EDT 2007


On 5/17/07, Iyer, Rahul <Rahul.Iyer at netapp.com> wrote:
>
>  Hi,
> the client and server weren't up to draft 10. These patches do that.
>

Hi Rahul

Your patch:
0001-Update-client-and-server-EXCHANGE_ID-to-draft-10.patch actually updates
the client CREATE_SESSION op to draft 10 (not exchange id, so the name is
wrong) in a similar way that my
0001-Move-client-create-session-xdr-to-minorversion1-10.patch does

Except:

- you leave the persist field in struct nfs41_create_session_args which
should be removed, and the SESSION4_FLAG_PERSIST flag should be used
instead.

- you don't update the nfs4_channel_attrs which have the stream_attr
removed.

- you declare the session flags in include/linux/nfs_xdr.h. since they are
shared with the server, they should be in include/linux/nfs4.h

and the server side is missing.

so we'll use the client and server patches i submitted to update
create_session-id to draft 10.


They also add a NFSERR_BADSESSION handler. (This should avoid the problems
> Marc was seeing).
>

These are fine, and have been added to the 4.1-sessions branch.

-->Andy

Regards
> rahul
>
>
> _______________________________________________
> pNFS mailing list
> pNFS at linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://linux-nfs.org/pipermail/pnfs/attachments/20070517/f049cd3c/attachment.htm 


More information about the pNFS mailing list