[pnfs] nfs_callback_down in nfs4_fill_super

[William A. (Andy) Adamson]

Hi Rahul

I'm in the sessions branch, where nothing is working (!). The client is in
nfs4_fill_super() calling rpc_ops->setup_session, which fails on
exchange_id.

              if (server->rpc_ops->setup_session) {
                        lock_kernel();
                        down_write(&server->nfs4_state->cl_sem);
                        err =
server->rpc_ops->setup_session(server->nfs4_state);
                        up_write(&server->nfs4_state->cl_sem);
                        unlock_kernel();

                        if (err) {
                                printk(KERN_EMERG "Couldn't mount using
minorversion %d\n", i);
                                /*
                                 * Shut down the callback service
                                 */
                                nfs_callback_down(i,
server->client->cl_xprt);

                                rpc_shutdown_client(server->client);
                        }

The client hits a BUG in mm/mempool due to the call to nfs_callback_down. I
don't think the callback channel has not been created, so this call is not
needed. Correct?

-->Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://linux-nfs.org/pipermail/pnfs/attachments/20070523/780ba65b/attachment.htm