[pnfs] Should v4.1 callbacks share NFS server code?

[Trond Myklebust]

On Fri, 2007-11-09 at 09:55 +0200, Benny Halevy wrote:
> Trond Myklebust wrote:
> > On Thu, 2007-11-08 at 16:00 -0800, Labiaga, Ricardo wrote:
> >> Although it sounds like a good time to consider sharing code, it also
> >> sounds like a project onto itself.  It also would delay the v4.1
> >> callback functionality considerably.
> >>
> >> Does a callback implementation that does not share code make sense as a
> >> first step? 
> > 
> > Yes.
> 
> I wish I had better insight into the code but I really hope
> we can somehow get to the state that the code is shared
> gradually rather than in an "all or nothing" project approach.
> 
> For example, even if the overall design is different on the server
> vs. the client, I'd still look for opportunities to refactor the
> existing server code so that the common parts can reused rather than
> copied.  Of course the trade off should be weighed for each use case
> but let's try to keep our minds open about it.

I'm not saying that client and server code can't share little utilities
etc. They can and do (for instance all the XDR code is common).

What I am saying is that the focus should not be on forcing the two into
the same mold. Rather, the focus should be on preserving the properties
that are essential for good client or server performance. So for
instance on the client, the callback code should work so as to not
introduce any delays. On the server, it should not screw up the free
socket buffer space calculations. etc...

Trond