[pnfs] [PATCH 0/14] linux-pnfs-2.6-latest pNFS client read I/O - Draft 13

[Trond Myklebust]

On Wed, 2007-11-14 at 12:11 -0500, William A. (Andy) Adamson wrote:

> for example in fs/nfs/read.c: nfs_read_rpcsetup()
> 
> ifdef CONFIG_PNFS
>         /* XXX pnfs_try_to_read_data should never return an error less than 0.
>         * ret == 0 means pnfs read succees.
>         * ret == 1 means do an NFSv4.1 read to the MDS.
>         */
>         if ((pnfs_try_to_read_data(data, call_ops)) <= 0)
>                 return;
> #endif /* CONFIG_PNFS*/
> 
>         nfs_initiate_read(data, NFS_CLIENT(inode), call_ops);
> }

The above is a seriously brilliant comment! Are we perhaps missing a
BUG_ON() there?

Trond