>> + if (page->index < end_index) >>> + return PAGE_CACHE_SIZE; >>> + if (page->index == end_index) >> why not just "else"? > > > we want to return 0 if end_index > page->index.... ok. got it :) Benny > >> + return ((i_size - 1) & ~PAGE_CACHE_MASK) + 1; >>> + } >>> + return 0;