[pnfs] [PATCH resend] missing include in nfs4filelayoutdev.c

[Benny Halevy]

On Nov. 26, 2007, 18:28 +0200, "William A. (Andy) Adamson" <andros at citi.umich.edu> wrote:
> Hi Benny
> 
> The 2.6.18.3 nfslayoutdriver module compiles for me without the include. I
> can put it in anyway...

Thanks!
I'm puzzled since what I get with linux-pnfs @ 65d750aa2801be586548ba5f2ddbebfea658c8a5
is that:

$ make
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CHK     include/linux/compile.h
  CC [M]  fs/nfs/nfs4filelayoutdev.o
fs/nfs/nfs4filelayoutdev.c: In function `device_create':
fs/nfs/nfs4filelayoutdev.c:130: error: `system_utsname' undeclared (first use in this function)
fs/nfs/nfs4filelayoutdev.c:130: error: (Each undeclared identifier is reported only once
fs/nfs/nfs4filelayoutdev.c:130: error: for each function it appears in.)
fs/nfs/nfs4filelayoutdev.c: At top level:
fs/nfs/nfs4filelayoutdev.c:493: warning: 'nfs4_pnfs_device_put' defined but not used
make[2]: *** [fs/nfs/nfs4filelayoutdev.o] Error 1
make[1]: *** [fs/nfs] Error 2
make: *** [fs] Error 2

Benny

> 
> -->Andy
> 
> On 11/26/07, Benny Halevy <bhalevy at panasas.com> wrote:
>> that's for the 2.6.18.3 kernel...
>>
>> benny
>>
>> On Nov. 26, 2007, 13:34 +0200, Benny Halevy <bhalevy at panasas.com> wrote:
>>> Please apply this patch.
>>> The module doesn't compile without it.
>>>
>>> Thanks,
>>>
>>> Benny
>>>
>>> On Oct. 22, 2007, 10:22 +0200, Benny Halevy <bhalevy at panasas.com> wrote:
>>>
>>> need to include <linux/utsname.h> for system_utsname
>>> (introduced in 604236c9aa5a4dfaa8a8f40ee77f45836af6292f)
>>>
>>> Signed-off-by: Benny Halevy <bhalevy at panasas.com>
>>> ---
>>>  fs/nfs/nfs4filelayoutdev.c |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/fs/nfs/nfs4filelayoutdev.c b/fs/nfs/nfs4filelayoutdev.c
>>> index dda1e55..7c77ce1 100644
>>> --- a/fs/nfs/nfs4filelayoutdev.c
>>> +++ b/fs/nfs/nfs4filelayoutdev.c
>>> @@ -40,6 +40,7 @@
>>>  #include <linux/sched.h>
>>>  #include <linux/spinlock.h>
>>>  #include <linux/hash.h>
>>> +#include <linux/utsname.h>
>>>
>>>  #include <linux/nfs4.h>
>>>  #include <linux/nfs_fs.h>
>> _______________________________________________
>> pNFS mailing list
>> pNFS at linux-nfs.org
>> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>>
>>
>