[pnfs] [PATCH] xs_tcp_read_request: unlock transport_lock only for RPC_REPLY

Benny Halevy bhalevy at panasas.com
Wed Nov 28 11:13:28 EST 2007


On Nov. 28, 2007, 18:06 +0200, Trond Myklebust <trond.myklebust at fys.uio.no> wrote:
> On Wed, 2007-11-28 at 17:57 +0200, Benny Halevy wrote:
>> 2. previously the common code would have called xprt_complete_rqst()
>> in the r != len case.  This seems like a bug to me as the request will be waken
>> up with a partially read reply and it could contain junk.
>> This implementation returns an error internally and drops the reply.
> 
> I'd prefer to see that as a separate patch, since it really is a
> separate issue from the cleanup. The other thing is that if correct,
> then we should be applying it to mainline too.
> 
sure. I will send this patch to you, cc the nfs mailing list.

Benny


More information about the pNFS mailing list