[pnfs] [PATCH 10/11] Add new back channel support object files to sunrpc module.

[Ricardo Labiaga]

On Wed, 2007-11-28 at 22:56 +0200, Benny Halevy wrote:
> Ricardo Labiaga wrote:
> > I failed to git add it.  
> 
> why?
> 

I do my work in a private git repository.  I commit changes that I want
as individual patches and then use git-format-patch to generate the
patch.  I guess not everyone does it this way?

> > That brings a good question though.
> > net/sunrpc/bc_svc.c currently stubs out bc_process() that does no work.
> > What's the preferred way of dealing with this work in progress?  Submit
> > a patch and have it in the history as a simple stub?
> >   
> While the work is ongoing you can just collect and maintain the patchset 
> in a branch
> using git-rebase--interactive to keep it tidy.  E.g. if you had a patch 
> introducing a stub
> and then a patch that implements it you can squash them together by 
> rebasing the branch to master
> And when we're happy with it we can then push it to the master branch.

Ah, thanks for the pointer.

In this particular case, I'll most likely resubmit the patch taking out
the dependency on the new file that I have not yet coded.

- ricardo


> > - ricardo
> >
> >
> > On Wed, 2007-11-28 at 15:57 +0200, Benny Halevy wrote:
> >   
> >> On Nov. 28, 2007, 6:25 +0200, ricardo.labiaga at netapp.com wrote:
> >>     
> >>> Signed-off-by: Ricardo Labiaga <ricardo.labiaga at netapp.com>
> >>> ---
> >>>  net/sunrpc/Makefile |    3 ++-
> >>>  1 files changed, 2 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> >>> index 5c69a72..6092cd6 100644
> >>> --- a/net/sunrpc/Makefile
> >>> +++ b/net/sunrpc/Makefile
> >>> @@ -11,6 +11,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o sched.o \
> >>>  	    auth.o auth_null.o auth_unix.o \
> >>>  	    svc.o svcsock.o svcauth.o svcauth_unix.o \
> >>>  	    rpcb_clnt.o timer.o xdr.o \
> >>> -	    sunrpc_syms.o cache.o rpc_pipe.o
> >>> +	    sunrpc_syms.o cache.o rpc_pipe.o \
> >>> +	    bc_svc.o backchannel_rqst.o
> >>>       
> >> Ricardo, net/sunrpc/bc_svc.c seems to missing...
> >>
> >> Benny
> >>
> >>     
> >>>  sunrpc-$(CONFIG_PROC_FS) += stats.o
> >>>  sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> >>>