[pnfs] [PATCH] increase number of RPC slots

Trond Myklebust trond.myklebust at fys.uio.no
Fri Oct 12 12:44:54 EDT 2007


On Fri, 2007-10-12 at 08:31 -0700, Marc Eshel wrote:
> From: Marc Eshel <eshel at almaden.ibm.com>
> 
> 
> ---
> 
>  include/linux/sunrpc/xprt.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
> index ae36773..5fc0141 100644
> --- a/include/linux/sunrpc/xprt.h
> +++ b/include/linux/sunrpc/xprt.h
> @@ -22,7 +22,7 @@ extern unsigned int xprt_udp_slot_table_
>  extern unsigned int xprt_tcp_slot_table_entries;
>  
>  #define RPC_MIN_SLOT_TABLE	(2U)
> -#define RPC_DEF_SLOT_TABLE	(16U)
> +#define RPC_DEF_SLOT_TABLE	(64U)
>  #define RPC_MAX_SLOT_TABLE	(128U)

NACK. You offer no justification for changing what is a global default
that affects NFSv2/v3/v4. I want to see numbers for a whole range of
workloads before I accept patches like this.

  Trond



More information about the pNFS mailing list